| commit | 12b62b053887c28cfd206b09ffeadb74619d9e33 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Fri Apr 20 15:35:18 2018 +0200 |
| committer | Dave Borowitz <dborowitz@google.com> | Fri Apr 27 12:25:45 2018 -0400 |
| tree | 359abca264ace2d385c8c9735b0c1c0c1af9e637 | |
| parent | 01b66cb5ff88ebaacf81c9b71915621fdac611b6 [diff] |
Split setter/getter interfaces out of CacheBinding
The CacheBinding interface now contains only setters. With "binding" in
the name, it indicates that this is the thing used from within
CacheModule to configure the interface.
Move all the getter methods into a new interface, CacheDef. This is the
type that is passed into {Memory,Persistent}CacheFactory, where the
cache setup internals need to query the configured values, but calling
setters at this point would be programmer error.
This has the side advantage of eliminating the need for throwing
RuntimeExceptions from H2CacheBindingProxy, and it is now clearer that
this is simply a delegate for the getter half of the interface.
Both of these interfaces are still implemented by the same CacheProvider
class, and it still retains the freeze-during-get behavior. It may be
possible to split it up, for example converting it to a normal builder
which produces a read-only CacheDef from its build method, but I wasn't
able to get that working with the asEagerSingleton binding magic used by
the current implementation.
Change-Id: I5c90f6eb17d257a127b2c52d70558c2f80655ec2
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.