commit f8578183f3dcac5b5fdd2cf6fe4c08aade489521
author David Ostrovsky <david@ostrovsky.org> Wed May 21 08:37:46 2014 +0200
committer David Ostrovsky <david.ostrovsky@gmail.com> Fri Jun 13 10:15:59 2014 +0000
tree 8f8a24cf0e65005e1a9312bd8346e7c609f21cf5
parent ba75ccf8cde713355952f8c1bcafa0de2673b641

WebSession: Prevent NPE in GitSmartHttpTools.isGitClient()

ContinuingHttpServletRequest doesn't have request URI. That cause

  public static boolean isInfoRefs(HttpServletRequest req) {
    return req.getRequestURI().endsWith(INFO_REFS_PATH)
    && VALID_SERVICES.contains(req.getParameter("service"));
  }

to throw NPE.

More robust implementation of isInfoRefs() could check for

  req.getRequestURI() != null

or swap the conditions.

Bug was filled against JGit project: [1].

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=435404

Change-Id: Iac85505720496b411814a6d050a7612d507bf3a6