Google Git
Sign in
gerrit / gerrit / f7707a1b03d45cc075a7c0f0322df040ca04d6c9
commitf7707a1b03d45cc075a7c0f0322df040ca04d6c9[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Fri Nov 26 12:36:59 2021 +0100
committerEdwin Kempin <ekempin@google.com>Mon Nov 29 09:38:58 2021 +0100
tree2d3ea96a7a6c2f0aedafdb73b4d5bf81bcbc7ba7
parent0994a56d14cade2f3117b9deebc5d28d5c93155e [diff]
Enable error level for the EqualsGetClass bug pattern in ErrorProne

The current code has some violations of this bug pattern that we ignore
because:

a) fixing the class would be an incompatible change and break API
   (Comment, AuditEvent)

b) fixing the class could potentially break things and would require a
   larger refactoring (index classes that are subclassed)

Two places were fixed:

1. BlameInfo: There is no subclassing, hence fixing it should be safe.

2. NotPredicate: There is no subclassing, hence fixing it should be
   safe. We make the class final to prevent any future subclassing.

Ignoring the violations for the existing code is not great, but at least
it allows us to enable this bug pattern so that new additional
violations will be prevented.

Bug: Issue 15062
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I74db5384c2a9867f46a26dc632f840f7d677b987
10 files changed
tree: 2d3ea96a7a6c2f0aedafdb73b4d5bf81bcbc7ba7
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.