| commit | 40d64f6d432e72d476b6200b7c3114416709ff45 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Nov 11 09:33:34 2015 -0800 |
| committer | Edwin Kempin <ekempin@google.com> | Wed Nov 11 09:35:11 2015 -0800 |
| tree | ec00586b928bd1ca654a334dbdeae191475805fb | |
| parent | 12088fc1b5f665d0530432b99adefdced2d7fc08 [diff] |
Notedb: Fix reviewedBy computation in ChangeData To find which users have reviewed a change we find all users that have posted a message or uploaded a patch set after the change owner has posted a message or uploaded a patch set. To do this we internally created ReviewedByEvents based on the changes messages and the patch sets and sorted them by date. When two actions were done with the same timestamp this could result in a wrong order. E.g. the owner uploads patch set 1 and then a user posts a review, we have 2 change messages and 1 patch set and they all can have the same timestamp. For the change message the correct order is guaranteed by respecting the order of the commits on the refs/changes/XX/YYYY/meta branch, but doing a sorting by timestamp in the reviewedBy computation may result in a wrong order. Because of this the ChangeIT#checkReviewedFlagBeforeAndAfterReview() was flaky when notedb was enabled. To fix the issue the sorting by timestamp is removed from the reviewedBy computation. This is possible by only relying on the change messages and not considering the patch sets. It's OK to ignore the patch set because any patch set creation also creates a change message. Change-Id: I959517ad562a0839b588fc2cebc4c2d05ee7a117 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.