Remove errFn from save(|Diff|Edit)Preferences
Change-Id: Id0f7deac5971296f3c8bef1f09a3d0435ca173cc
diff --git a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.ts b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.ts
index 580a75c..1c6e0b6 100644
--- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.ts
+++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.ts
@@ -748,14 +748,7 @@
});
}
- savePreferences(prefs: PreferencesInput): Promise<Response>;
-
- savePreferences(
- prefs: PreferencesInput,
- errFn: ErrorCallback
- ): Promise<Response | undefined>;
-
- savePreferences(prefs: PreferencesInput, errFn?: ErrorCallback) {
+ savePreferences(prefs: PreferencesInput): Promise<Response> {
// Note (Issue 5142): normalize the download scheme with lower case before
// saving.
if (prefs.download_scheme) {
@@ -766,45 +759,28 @@
method: HttpMethod.PUT,
url: '/accounts/self/preferences',
body: prefs,
- errFn,
reportUrlAsIs: true,
});
}
- saveDiffPreferences(prefs: DiffPreferenceInput): Promise<Response>;
-
- saveDiffPreferences(
- prefs: DiffPreferenceInput,
- errFn: ErrorCallback
- ): Promise<Response | undefined>;
-
- saveDiffPreferences(prefs: DiffPreferenceInput, errFn?: ErrorCallback) {
+ saveDiffPreferences(prefs: DiffPreferenceInput): Promise<Response> {
// Invalidate the cache.
this._cache.delete('/accounts/self/preferences.diff');
return this._restApiHelper.send({
method: HttpMethod.PUT,
url: '/accounts/self/preferences.diff',
body: prefs,
- errFn,
reportUrlAsIs: true,
});
}
- saveEditPreferences(prefs: EditPreferencesInfo): Promise<Response>;
-
- saveEditPreferences(
- prefs: EditPreferencesInfo,
- errFn: ErrorCallback
- ): Promise<Response | undefined>;
-
- saveEditPreferences(prefs: EditPreferencesInfo, errFn?: ErrorCallback) {
+ saveEditPreferences(prefs: EditPreferencesInfo): Promise<Response> {
// Invalidate the cache.
this._cache.delete('/accounts/self/preferences.edit');
return this._restApiHelper.send({
method: HttpMethod.PUT,
url: '/accounts/self/preferences.edit',
body: prefs,
- errFn,
reportUrlAsIs: true,
});
}
diff --git a/polygerrit-ui/app/services/services/gr-rest-api/gr-rest-api.ts b/polygerrit-ui/app/services/services/gr-rest-api/gr-rest-api.ts
index 8f11a60..8a0f912 100644
--- a/polygerrit-ui/app/services/services/gr-rest-api/gr-rest-api.ts
+++ b/polygerrit-ui/app/services/services/gr-rest-api/gr-rest-api.ts
@@ -232,26 +232,10 @@
getDiffPreferences(): Promise<DiffPreferencesInfo | undefined>;
saveDiffPreferences(prefs: DiffPreferenceInput): Promise<Response>;
- saveDiffPreferences(
- prefs: DiffPreferenceInput,
- errFn: ErrorCallback
- ): Promise<Response | undefined>;
- saveDiffPreferences(
- prefs: DiffPreferenceInput,
- errFn?: ErrorCallback
- ): Promise<Response>;
getEditPreferences(): Promise<EditPreferencesInfo | undefined>;
saveEditPreferences(prefs: EditPreferencesInfo): Promise<Response>;
- saveEditPreferences(
- prefs: EditPreferencesInfo,
- errFn: ErrorCallback
- ): Promise<Response | undefined>;
- saveEditPreferences(
- prefs: EditPreferencesInfo,
- errFn?: ErrorCallback
- ): Promise<Response>;
getAccountEmails(): Promise<EmailInfo[] | undefined>;
deleteAccountEmail(email: string): Promise<Response>;