| commit | f6b479a5337e014dae90a9420a4853a5d4fa2ded | [log] [tgz] |
|---|---|---|
| author | Khai Do <zaro0508@gmail.com> | Tue Dec 08 23:44:34 2015 -0800 |
| committer | Khai Do <zaro0508@gmail.com> | Mon Mar 21 19:40:59 2016 -0700 |
| tree | 3c7efd037365f000a4ea8d0c2e9e2059ff109ad4 | |
| parent | cb4afa34a8f9bab638a0c15673dee3a05c798c1a [diff] |
Fix inconsistent notifications on vote removal Change Ie4f05fafb73a implemented a feature to allow direct removal of a vote from the Gerrit UI. Clicking reply on the Gerrit UI and setting the vote to 0 is essentially the same thing as clicking 'X' on the vote. The difference is that Gerrit will fire a comment-added event on the reply however it will not fire an event when users remove the vote by clicking the 'X'. This is inconsistent behavior. This change attempts to fix this inconsistent behavior by also sending a comment-added event when users click on the 'X' to remove a vote. The vote removal appear as the following comment: "Zaro Removed Code-Review-2 by Russell Westbrook <rwestbrook@localhost.com>" Email preview: http://paste.openstack.org/show/485472 Bug: issue 3701 Change-Id: I279cb5b411d8c8e37243a5d3b734a8f002523d97
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.