commit f63ec844b59f6f198257ff899a3c8423c1a72121
author David Pursehouse <david.pursehouse@sonymobile.com> Fri Oct 11 19:14:22 2013 +0900
committer David Pursehouse <david.pursehouse@sonymobile.com> Fri Oct 11 19:16:03 2013 +0900
tree 29b43acf22a93cfe2e82cdf942fc138773d538c8
parent 3670fce26209017ffc88d83a1abfb7546689166a

Fix: Editing the commit message publishes draft patch set

If a patch set is draft, and the commit message is edited from
the Web UI, the new patch set is not a draft.

The draft status was being set on the new patch set, but should
be set on the patch set inserter.

Bug: Issue 2180
Change-Id: I035df9c9d6e46b0595fb1d9b017d284551d1b261

gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
index 07ecce2..fd2910f 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
@@ -375,7 +375,6 @@
       newPatchSet.setCreatedOn(new Timestamp(now.getTime()));
       newPatchSet.setUploader(user.getAccountId());
       newPatchSet.setRevision(new RevId(newCommit.name()));
-      newPatchSet.setDraft(originalPS.isDraft());
 
       final String msg =
           "Patch Set " + newPatchSet.getPatchSetId()
@@ -387,6 +386,7 @@
           .setMessage(msg)
           .setCopyLabels(true)
           .setValidatePolicy(RECEIVE_COMMITS)
+          .setDraft(originalPS.isDraft())
           .insert();
 
       return change.getId();