Google Git
Sign in
gerrit / gerrit / f543bd9bdfb1b1a704872e15d631ec44e583d857
commitf543bd9bdfb1b1a704872e15d631ec44e583d857[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Wed Oct 26 14:04:51 2016 +0200
committerEdwin Kempin <ekempin@google.com>Wed Oct 26 14:46:49 2016 +0200
treeab9372f9080b23e29499d06f23460d5bee2e246f
parentaf1d4402898d2fba8483d1eaa26d01cac3076f2c [diff]
ReplyBox: Don't fail if permitted label is missing in labels

For ChangeInfo it is expected that all labels from the
'permitted_labels' field are contained in the 'labels' field. If this
was not the case the UI failed with the following error:

  SEVERE: Exception caught: (TypeError) : Cannot read property 'values' of undefined
  Class$S471: Exception caught: (TypeError) : Cannot read property 'values' of undefined
    at Unknown.Throwable_2(gerrit_ui-0.js)
    ...
  Caused by: Class$S171: (TypeError) : Cannot read property 'values' of undefined
    at Unknown.$_values(gerrit_ui-0.js)
    at Unknown.$values_0(gerrit_ui-0.js)
    at Unknown.$valueSet(gerrit_ui-0.js)
    at Unknown.renderLabels(gerrit_ui-0.js)
    at Unknown.ReplyBox(gerrit_ui-0.js)
    at Unknown.onReply_2(gerrit_ui-0.js)
    ...

This error prevents posting of replies on a change.

Although this should never happen, the UI should not fail like this.
Hence handle this case. This means the voting buttons for this label
would be missing, but at least posting a reply (other labels,
comments) is still working.

Change-Id: I27d3ce0784028c332378f6a390ab48d906fe35ea
Signed-off-by: Edwin Kempin <ekempin@google.com>
1 file changed
tree: ab9372f9080b23e29499d06f23460d5bee2e246f
  1. .settings/
  2. bucklets/
  3. contrib/
  4. Documentation/
  5. gerrit-acceptance-framework/
  6. gerrit-acceptance-tests/
  7. gerrit-antlr/
  8. gerrit-cache-h2/
  9. gerrit-common/
  10. gerrit-elasticsearch/
  11. gerrit-extension-api/
  12. gerrit-gpg/
  13. gerrit-gwtdebug/
  14. gerrit-gwtexpui/
  15. gerrit-gwtui/
  16. gerrit-gwtui-common/
  17. gerrit-httpd/
  18. gerrit-index/
  19. gerrit-launcher/
  20. gerrit-lucene/
  21. gerrit-main/
  22. gerrit-oauth/
  23. gerrit-openid/
  24. gerrit-patch-commonsnet/
  25. gerrit-patch-jgit/
  26. gerrit-pgm/
  27. gerrit-plugin-api/
  28. gerrit-plugin-archetype/
  29. gerrit-plugin-gwt-archetype/
  30. gerrit-plugin-gwtui/
  31. gerrit-plugin-js-archetype/
  32. gerrit-prettify/
  33. gerrit-reviewdb/
  34. gerrit-server/
  35. gerrit-sshd/
  36. gerrit-util-cli/
  37. gerrit-util-http/
  38. gerrit-util-ssl/
  39. gerrit-war/
  40. lib/
  41. plugins/
  42. polygerrit-ui/
  43. ReleaseNotes/
  44. tools/
  45. website/
  46. .bazelrc
  47. .buckconfig
  48. .buckversion
  49. .editorconfig
  50. .gitignore
  51. .gitmodules
  52. .mailmap
  53. .pydevproject
  54. .watchmanconfig
  55. BUCK
  56. BUILD
  57. COPYING
  58. INSTALL
  59. README.md
  60. SUBMITTING_PATCHES
  61. VERSION
  62. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Buck and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && buck build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.