Google Git
Sign in
gerrit / gerrit / f51cf2323b627c5ea76e8b6f8b37fb195be0fd25
commitf51cf2323b627c5ea76e8b6f8b37fb195be0fd25[log] [tgz]
authorDavid Ostrovsky <david@ostrovsky.org>Fri Aug 31 06:19:26 2018 +0200
committerDavid Ostrovsky <david@ostrovsky.org>Fri Aug 31 06:35:46 2018 +0200
tree9fb6750b4642ad04dcc75170726e6b0d8d00d75d
parent00d6bca8d0bc0e0e387b6cff89593abaefe92ae1 [diff]
Bazel: Move java/com/google/gerrit/index:query_parser to antlr3 package

In I75d6bc4d7a antlr3 grammar sources were moved from gerrit-antlr
package, but the java_library rule query_parser were missed to also be
moved to antlr3 package. This is very unusual in Bazel toolchain to keep
the sources in one package and build them in another. This leads to a
problem: restricting package_group in java_package_configuration doesn't
lead to the desired effect, as discussed in this issue: [1].

Moving the query_parser rule to the antlr3 package harmonize the
location of the java_library rule to the same package where the sources
are located and it also fixes the problem, that error prone warnings are
not reported any more for the antlr3 grammar source in new toolchain,
that doesn't list antlr3 in the package_group. ntlr3 grammar code is
generated code and we would rather avoid reporting any issues in that
code.

[1] https://github.com/bazelbuild/bazel/issues/6010
Change-Id: Iff32b6133ff7bf3f045a20fcb635d690d76e3b89
4 files changed
tree: 9fb6750b4642ad04dcc75170726e6b0d8d00d75d
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-acceptance-tests/
  6. gerrit-gwtdebug/
  7. gerrit-gwtui/
  8. gerrit-gwtui-common/
  9. gerrit-plugin-gwtui/
  10. java/
  11. javatests/
  12. lib/
  13. plugins/
  14. polygerrit-ui/
  15. prolog/
  16. prologtests/
  17. proto/
  18. resources/
  19. tools/
  20. webapp/
  21. .bazelproject
  22. .bazelrc
  23. .editorconfig
  24. .git-blame-ignore-revs
  25. .gitignore
  26. .gitmodules
  27. .mailmap
  28. .pydevproject
  29. BUILD
  30. COPYING
  31. INSTALL
  32. README.md
  33. SUBMITTING_PATCHES
  34. version.bzl
  35. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.