Removing unnecessary test from ChangeIT and updating test names
There was an unnecessary test in ChangeIT added when bug fixing. I
removed that test as well as renaming the other new test to make its
purpose more clear. Corrected other nits like unnecessary newlines.
Change-Id: Iac54622cbc8fa961535904dab700e1fbbf9af58c
diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/change/ChangeIT.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/change/ChangeIT.java
index baa21cc..c79b198 100644
--- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/change/ChangeIT.java
+++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/change/ChangeIT.java
@@ -264,33 +264,18 @@
}
@Test
- public void queryChangesReviewerAfterReview() throws Exception {
+ public void checkReviewedFlagBeforeAndAfterReview() throws Exception {
PushOneCommit.Result r = createChange();
AddReviewerInput in = new AddReviewerInput();
in.reviewer = user.email;
gApi.changes()
- .id("p~master~" + r.getChangeId())
+ .id(r.getChangeId())
.addReviewer(in);
setApiUser(user);
assertNull(get(r.getChangeId()).reviewed);
revision(r).review(ReviewInput.recommend());
-
assertTrue(get(r.getChangeId()).reviewed);
}
-
- @Test
- public void queryChangesReviewerNotReviewed() throws Exception {
- PushOneCommit.Result r = createChange();
- AddReviewerInput in = new AddReviewerInput();
- in.reviewer = user.email;
- gApi.changes()
- .id("p~master~" + r.getChangeId())
- .addReviewer(in);
-
- setApiUser(user);
-
- assertNull(get(r.getChangeId()).reviewed);
- }
}