Google Git
Sign in
gerrit / gerrit / f4c3ff89c9169f54b8ba23d19ed36560c6ab8ca7
commitf4c3ff89c9169f54b8ba23d19ed36560c6ab8ca7[log] [tgz]
authorNasser Grainawi <nasser.grainawi@linaro.org>Mon Apr 15 09:38:00 2024 -0600
committerNasser Grainawi <nasser.grainawi@linaro.org>Mon Apr 15 09:43:01 2024 -0600
tree302373b31065655178dfaf1a87971d2b378e0882
parent56a18465bad6201c39de813f6fc39277fdc7b79a [diff]
ServerPlugin: Fix buggy Optional.orElse()

Fix an issue with creating child injectors using a buggy
Optional.orElse() pattern when creating the new root injector for a
plugin. This was causing two new injectors to always be created for the
ServerPluginInfoModule.

This pattern was fixed elsewhere in change Icab4115998f and was fixed in
ServerPlugin in the currently reverted change I8633083d97. This splits
out the fix from the rest of change I8633083d97 so that it can be tested
independently.

Change-Id: I2e62662f5801e02bf8c2bc2ae0ca87dbe58b20f2
Release-Notes: Fix Optional.orElse() always causing creation of two injectors for ServerPluginInfoModule
1 file changed
tree: 302373b31065655178dfaf1a87971d2b378e0882
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. package.json
  36. README.md
  37. SUBMITTING_PATCHES
  38. version.bzl
  39. web-dev-server.config.mjs
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.