Respect manual_review preference in diff view The ability to modify the preference in the diff settings will be added in a later change. Bug: Issue 4676 Change-Id: I8c335acd9c50344714e56901f82c09327e7f4366
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.html b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.html index 6cb92e7..8b6d82f 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.html +++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.html
@@ -509,6 +509,29 @@ assert.isTrue(link.hasAttribute('download')); }); + test('_prefs.manual_review is respected', () => { + const saveReviewedStub = sandbox.stub(element, '_saveReviewedState', + () => Promise.resolve()); + sandbox.stub(element.$.diff, 'reload'); + + element._loggedIn = true; + element.params = { + view: Gerrit.Nav.View.DIFF, + changeNum: '42', + patchNum: '2', + basePatchNum: '1', + path: '/COMMIT_MSG', + }; + element._prefs = {manual_review: true}; + flushAsynchronousOperations(); + + assert.isFalse(saveReviewedStub.called); + element._prefs = {}; + flushAsynchronousOperations(); + + assert.isTrue(saveReviewedStub.called); + }); + test('file review status', () => { const saveReviewedStub = sandbox.stub(element, '_saveReviewedState', () => Promise.resolve()); @@ -522,6 +545,7 @@ basePatchNum: '1', path: '/COMMIT_MSG', }; + element._prefs = {}; flushAsynchronousOperations(); const commitMsg = Polymer.dom(element.root).querySelector(