| commit | f3c75eae24195cf338fdd44a772b2fb5f7516e6a | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Jul 05 13:16:55 2018 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Jul 06 09:51:43 2018 +0200 |
| tree | 2f2b91228d18c97f6ce849adf346f58a2ebd9bf2 | |
| parent | a6309f75bb9e94e7ff7245e5268b8ea3c8b18582 [diff] |
AccessSection.getPermissions: Return defensive copy of list If AccessSection directly returns its modifyable list, callers can modify the list outside of AccessSection. This is bad because this way it is possible to violate assumptions of the AccessSection class. E.g. AccessSection makes sure that the permission list cannot contain duplicate permissions. Having duplicate permissions in the permission list can lead to severe problems. E.g. duplicate permissions on an access section of the All-Projects project make the permissions of the All-Project project unreadable and Gerrit effectively stops working. This is because ProjectState#getLocalAccessSections() filters out some permissions on the All-Projects project by getting the list of permissions from AccessSection and setting the filtered list back on AccessSection. If the list that was retrieved from AccessSection contained duplicate permissions, setting back the list failed with IllegalArgumentException since AccessSection#setPermissions(List<Permission>) doesn't allow duplicate permissions. A similar issue was already fixed by change I5222cd9174 and change Ief24c6e82f. Ideally we would return an ImmutableList from AccessSection.getPermissions() but we cannot use ImmutableList in classes that are used by the GWT UI. Change-Id: I61f0baf6deb5c4ba1b609aacaabeb1f149f444d9 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.