Improve error message for grayed out submit buttons, 2nd edition
When the submit button is grayed out because the changes would not
merge cleanly, let the user know in the tool tip. To do this properly
we need to first check for the current change and then for all other
changes in the same topic.
There is a fine distinction between BLOCKED_TOPIC_TOOLTIP ("Other
changes in this topic are not ready") and CLICK_FAILURE_OTHER_TOOLTIP
("Clicking the button would fail for other changes in the topic.").
Former indicates that a label is missing whereas the latter indicates
a dry run of a submission has failed (all labels ok, but the submission
is likely to fail)
This subtle behavioral difference is of course tested in ActionsIT,
where you'll have two approved changes, which are colliding with
upstream though.
Change-Id: I7a8389e98d9e20794b06245dab007d93fed7ccf3
2 files changed
