|author||Patrick Hiesel <firstname.lastname@example.org>||Wed Jul 21 14:19:38 2021 +0200|
|committer||Patrick Hiesel <email@example.com>||Thu Jul 29 10:55:20 2021 +0200|
LabelTypes: Return an Optional to make clear that value can be absent When asking LabelTypes for a LabelType by name or ID, that LabelType is only returned if the project has a label with name or ID configured. Most places in Gerrit correctly handled this implicit behavior, but new code for SubmitRequirements (ChangeField:getMaxMinAnyLabels) did not which made it fail with a NullPointerException in case a label that was voted on the change was removed from project.config since the vote was granted. In this commit, we fix the NPE by reworking LabelTypes to return an Optional which also makes it so that this programmer error can't occur in the future. Change-Id: I9e0f3a940ce21ef1e46b3dbb1675267ae1d76459
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.