Google Git
Sign in
gerrit / gerrit / f197138648b82996fc8896659373451788e05f4b
commitf197138648b82996fc8896659373451788e05f4b[log] [tgz]
authorWyatt Allen <wyatta@google.com>Tue Aug 29 13:22:15 2017 -0700
committerWyatt Allen <wyatta@google.com>Wed Aug 30 10:39:15 2017 -0700
tree77b16d51551558ce6e9371a61b1b0d7233c2f382
parentadc944cbada457d10580cac3f4a0c63b215f8cd5 [diff]
Show 404 for URLs that match no client route

URLs can be routed to PolyGerrit based on their prefix, even if they do
not correspond to a valid route in their suffix. For example, the route
"/c/foo/bar/baz" will not match any of PolyGerrit's client routes, but
is routed to PolyGerrit because it starts with "/c/". Because PolyGerrit
routes did not not handle unmatchable URLs, the result would be an
uninformative blank screen.

With this change, a catchall is added to the end of PolyGerrit's client
routes and it renders a 404 message if matched.

Bug: Issue 7071
Change-Id: I859e3de98631395225cb5329eb4151b3e1b9da05
2 files changed
tree: 77b16d51551558ce6e9371a61b1b0d7233c2f382
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-cache-h2/
  7. gerrit-common/
  8. gerrit-elasticsearch/
  9. gerrit-extension-api/
  10. gerrit-gpg/
  11. gerrit-gwtdebug/
  12. gerrit-gwtexpui/
  13. gerrit-gwtui/
  14. gerrit-gwtui-common/
  15. gerrit-httpd/
  16. gerrit-index/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-gwtui/
  27. gerrit-prettify/
  28. gerrit-reviewdb/
  29. gerrit-server/
  30. gerrit-sshd/
  31. gerrit-test-util/
  32. gerrit-util-cli/
  33. gerrit-util-http/
  34. gerrit-util-ssl/
  35. gerrit-war/
  36. lib/
  37. plugins/
  38. polygerrit-ui/
  39. ReleaseNotes/
  40. tools/
  41. website/
  42. .bazelproject
  43. .editorconfig
  44. .git-blame-ignore-revs
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. .pydevproject
  49. BUILD
  50. COPYING
  51. fake_pom.xml
  52. INSTALL
  53. README.md
  54. SUBMITTING_PATCHES
  55. version.bzl
  56. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.