Fix template problems with gr-create-repo-dialog
Change-Id: I9d52653cede4c2d1f4108a1e81a05a9f37d5b1e2
diff --git a/polygerrit-ui/app/BUILD b/polygerrit-ui/app/BUILD
index 980abb4..47c820a 100644
--- a/polygerrit-ui/app/BUILD
+++ b/polygerrit-ui/app/BUILD
@@ -95,7 +95,6 @@
# TODO: fix problems reported by template checker in these files.
ignore_templates_list = [
"elements/admin/gr-admin-view/gr-admin-view_html.ts",
- "elements/admin/gr-create-repo-dialog/gr-create-repo-dialog_html.ts",
"elements/admin/gr-group-members/gr-group-members_html.ts",
"elements/admin/gr-permission/gr-permission_html.ts",
"elements/admin/gr-plugin-list/gr-plugin-list_html.ts",
diff --git a/polygerrit-ui/app/elements/admin/gr-create-repo-dialog/gr-create-repo-dialog.ts b/polygerrit-ui/app/elements/admin/gr-create-repo-dialog/gr-create-repo-dialog.ts
index 63f6601..83c33d5 100644
--- a/polygerrit-ui/app/elements/admin/gr-create-repo-dialog/gr-create-repo-dialog.ts
+++ b/polygerrit-ui/app/elements/admin/gr-create-repo-dialog/gr-create-repo-dialog.ts
@@ -30,13 +30,19 @@
import {
BranchName,
GroupId,
+ GroupName,
ProjectInput,
RepoName,
} from '../../../types/common';
import {AutocompleteQuery} from '../../shared/gr-autocomplete/gr-autocomplete';
import {appContext} from '../../../services/app-context';
+import {convertToString} from '../../../utils/string-util';
declare global {
+ interface HTMLElementEventMap {
+ 'text-changed': CustomEvent;
+ 'value-changed': CustomEvent;
+ }
interface HTMLElementTagNameMap {
'gr-create-repo-dialog': GrCreateRepoDialog;
}
@@ -139,4 +145,20 @@
return groups;
});
}
+
+ handleRightsTextChanged(e: CustomEvent) {
+ this.set('_repoConfig.parent', e.detail.value as GroupName);
+ }
+
+ handleOwnerTextChanged(e: CustomEvent) {
+ this._repoOwner = e.detail.value;
+ }
+
+ handleOwnerValueChanged(e: CustomEvent) {
+ this._repoOwnerId = e.detail.value as GroupId;
+ }
+
+ convertToString(value?: unknown) {
+ return convertToString(value);
+ }
}
diff --git a/polygerrit-ui/app/elements/admin/gr-create-repo-dialog/gr-create-repo-dialog_html.ts b/polygerrit-ui/app/elements/admin/gr-create-repo-dialog/gr-create-repo-dialog_html.ts
index d0a6b7f..97cb194 100644
--- a/polygerrit-ui/app/elements/admin/gr-create-repo-dialog/gr-create-repo-dialog_html.ts
+++ b/polygerrit-ui/app/elements/admin/gr-create-repo-dialog/gr-create-repo-dialog_html.ts
@@ -51,9 +51,10 @@
<span class="value">
<gr-autocomplete
id="rightsInheritFromInput"
- text="{{_repoConfig.parent}}"
+ text="[[convertToString(_repoConfig.parent)]]"
query="[[_query]]"
placeholder="Optional, defaults to 'All-Projects'"
+ on-text-changed="handleRightsTextChanged"
>
</gr-autocomplete>
</span>
@@ -63,9 +64,11 @@
<span class="value">
<gr-autocomplete
id="ownerInput"
- text="{{_repoOwner}}"
- value="{{_repoOwnerId}}"
+ text="[[convertToString(_repoOwner)]]"
+ value="[[convertToString(_repoOwnerId)]]"
query="[[_queryGroups]]"
+ on-text-changed="handleOwnerTextChanged"
+ on-value-changed="handleOwnerValueChanged"
>
</gr-autocomplete>
</span>
