commit f0ebfdcfc50ad4026f002d54d5e5ca910cfbb448
author Becky Siegel <beckysiegel@google.com> Mon Oct 02 12:01:19 2017 +0100
committer Paladox none <thomasmulhall410@yahoo.com> Tue Feb 06 16:45:26 2018 +0000
tree 18aef5f2d99d372c57c831ac132ef0a688691dd6
parent 525c98bf3d75b73c216f5b50113ea2eb6be687b7

Disallow tabbing on paper-button

Because you can already tab through gr-buttons, the paper-button made it
so that each button had two tabs. The tabindex should only be on the
gr-buttons, so disallow on paper-button. For easy demonstration of this
issue, try to tab through the labels on the reply dilog.

Change-Id: Ibc1e7d753f3cda1786d09f81433656c9d3282305
(cherry picked from commit 048e8dc960e1c7df14977fbeaa92d9b983a86236)

polygerrit-ui/app/elements/shared/gr-button/gr-button.html

diff --git a/polygerrit-ui/app/elements/shared/gr-button/gr-button.html b/polygerrit-ui/app/elements/shared/gr-button/gr-button.html
index c0b17af..9be6497 100644
--- a/polygerrit-ui/app/elements/shared/gr-button/gr-button.html
+++ b/polygerrit-ui/app/elements/shared/gr-button/gr-button.html
@@ -116,7 +116,7 @@
         color: #aaa;
       }
     </style>
-    <paper-button raised="[[!link]]" disabled="[[disabled]]">
+    <paper-button raised="[[!link]]" disabled="[[disabled]]" tabindex="-1">
       <content></content>
       <i class="downArrow"></i>
     </paper-button>