commit	ed411a8dfebded9fd375d3fa6a214112cf4d0c57	[log] [tgz]
author	Edwin Kempin <ekempin@google.com>	Wed Sep 18 11:26:14 2019 +0200
committer	Edwin Kempin <ekempin@google.com>	Wed Sep 18 11:54:37 2019 +0200
tree	3953ad84932f9b43a6864e15a415fc4bcd020043
parent	17f7dfe7e3aacb2b9f05c9de718106b7d1531d08 [diff]

Fix exception handling when reading value from REST response

To fail with ISE a REST endpoint can either throw an exception or return
Response.InternalServerError (since change Ie58b4ace6). If
Response.InternalServerError is returned as response and the client
tries to read its value this fails with an UnsupportedOperationException
and the original cause for the ISE is lost. Fix this by throwing the
original cause from Response.InternalServerError#value(). Doing this
requires to handle exceptions when the Response#value() method is
called, but this seems to be manageable. The alternative would be to
revert change Ie58b4ace6.

The current situation is especially bad for analysing test failures that
are caused by ISEs because in this case the test fails with the
UnsupportedOperationException that is thrown by
Response.InternalServerError#value(), but we need to know the original
cause.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I89c0c68bf25a550b9b9be577f42f73c7752f3036

38 files changed

tree: 3953ad84932f9b43a6864e15a415fc4bcd020043

README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.