| commit | ef8fafbed08f57415c3650348a543817b70c871f | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Tue Dec 10 16:47:26 2019 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Wed Dec 11 13:09:07 2019 +0100 |
| tree | 77aa0c682b0368ef545ed41a254f4f5efb9dafe2 | |
| parent | 708b38359ffe30e07f84c10759e97fd19b3dc420 [diff] |
RetryHelper: Allow arbitrary string as action type The action type is used for 2 purposes: 1. to determine the default timeout for executing the action 2. as bucket for all retry metrics By making action type a String (instead of limiting it to the values of the ActionType enum) we allow plugins and organisation-specific integrations (e.g. at Google) to define additional action types. This is useful if there are action kinds that should use a different default timeout or a different metric bucket. At Google, besides the REST API we have another internal API that is mainly used by bots and we want retries that are triggered through this API to be distinguishable in the metrics. Hence for retries that are done through this API we want to set another/custom action type. For the default action types (those defined by the ActionType enum) we read the default timeouts from gerrit.config once when RetryHelper is initialized. For other action types we read the default timeout when it is needed for the first time. Then the value is cached so that also these default timeouts are read only once too. The reading of these additional default timeouts must be thread-safe so that the map that caches the default timeouts is updated only by one thread. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Icbb395d7921864f0f2717d50a816d6a37e9ac863
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.