Make gr-diff-styles clearer and more specific The 700 lines of css rules in gr-diff-styles are hard to reason about, because they refer to all of gr-diff and its subcomponents. We cannot move styles into subcomponents such as <gr-diff-row>, because gr-diff components cannot have a render root. Otherwise selection across components would break. But we would still like to group and sort the styles better, with two goals in mind: 1. Coming from a component you should be able to easily find the css rules that are relevant for this component only. 2. Coming from a css rule it should be obvious where the mentioned css classes are defined without searching the entire code base. As a first step in this change we only make all the css rules more specific, often by just prepending the relevant gr-diff component to the rule. This was done by searching through all diff components and looking up where each of the css class names were used. That was a lot of manual labor. Corrected was then tested by using Dev Helper and checking some random diffs including text selection. We will follow up with a change that sorts these rules and potentially breaks them up into smaller dedicated chunks. Release-Notes: skip Change-Id: Ie88b210dd250d86a558d225dae13bf9cc7bd49fc
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.