Refactoring: Replace `EditPatchSetNum` with EDIT Also replace instances of the string 'edit` with the constant `EDIT`. Release-Notes: skip Change-Id: I9cd5ac3fa7b99b542a663b63618cddb40a7b5730
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts index 4cfec21..c9dcbfb 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
@@ -59,7 +59,7 @@ ChangeId, ChangeInfo, CommitId, - EditPatchSetNum, + EDIT, NumericChangeId, PARENT, PatchRange, @@ -1816,7 +1816,7 @@ ); assert.isTrue( callCompute( - {basePatchNum: 1 as BasePatchSetNum, patchNum: EditPatchSetNum}, + {basePatchNum: 1 as BasePatchSetNum, patchNum: EDIT}, createAppElementChangeViewParams() ) ); @@ -1837,7 +1837,7 @@ assert.equal(element._patchRange.patchNum, undefined); change.revisions['bar'] = { - _number: EditPatchSetNum, + _number: EDIT, basePatchNum: 1 as BasePatchSetNum, commit: { ...createCommit(), @@ -1848,7 +1848,7 @@ // When edit is set, but not patchNum, then switch to edit ps. element._processEdit(change); - assert.equal(element._patchRange.patchNum, EditPatchSetNum); + assert.equal(element._patchRange.patchNum, EDIT); // When edit is set, but patchNum as well, then keep patchNum. element._patchRange.patchNum = 5 as RevisionPatchSetNum; @@ -1991,7 +1991,7 @@ sinon .stub(element, '_getPreferences') .returns(Promise.resolve(createPreferences())); - element._patchRange = {patchNum: EditPatchSetNum}; + element._patchRange = {patchNum: EDIT}; await element.performPostChangeLoadTasks(); assert.strictEqual(element._selectedRevision, revision3); }); @@ -2064,12 +2064,12 @@ const promise = mockPromise(); sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { assert.equal(args.length, 2); - assert.equal(args[1]!.patchNum, EditPatchSetNum); // patchNum + assert.equal(args[1]!.patchNum, EDIT); // patchNum promise.resolve(); }); element.set('_change.revisions.rev2', { - _number: EditPatchSetNum, + _number: EDIT, }); await flush();