| commit | ee2016c2d77f8334ce250b679949ac76125760fe | [log] [tgz] |
|---|---|---|
| author | Wyatt Allen <wyatta@google.com> | Tue Oct 31 13:41:52 2017 -0700 |
| committer | Wyatt Allen <wyatta@google.com> | Wed Nov 01 10:58:50 2017 -0700 |
| tree | 5de29113ddead56003ca39749a7e8561fd94573c | |
| parent | 2f76916b669a36f510497a67bcbad4efd90be773 [diff] |
Do not interpret custom dashboard spec when dashboard user is specified User dashboards have URLs like /dashboard/<email> and custom dashboards have URLs like /dashboard/?title=Title&foo=bar. These two routes were being mapped to the same handler, which interpreted the presence of any CGI parameters to differentiate the custom dashboard view. This broke UI switching from the dashboard (our landing page), because a URL like /dashboard/self?polygerrit=1 would show a custom dashboard rather than the user's dashboard. With this change, the two URL styles use separate patterns and separate route handlers. In this way, the user dashboard route will not attempt to interpret the query params intended for the serevr (but which can be included in any route). UI switching continues to be unsupported from custom dashboard view, but it's important to fix this regression on our landing page. Bug: crbug.com/779665 Change-Id: Idc8ba627e7743a891168bc80bb00c360be78ce92
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.