| commit | ed0b6dadf87010ac17c8156d530003280c7644c6 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Fri Oct 06 11:37:19 2017 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Oct 06 12:49:23 2017 +0200 |
| tree | 8d728550a7d36433c16314bf54ef6e5407259214 | |
| parent | 8eaa652dec10b13eaac29886a796069705e9a49d [diff] |
Fix migration of mute stars
Schema migration 161 which should migrate 'mute' stars to 'reviewed'
stars was pretty broken:
1. It didn't allow non-fast-forward updates.
2. It didn't set the correct oldId in the ReceiveCommands.
3. It checked for 'mute' labels, but actually the label is
'mute/<patch-set-number>'.
As result of this the schema migration didn't update any star refs.
There are 2 possibilities to fix this:
1. Fix schema migration 161 (implemented in this change):
- The migration will not be done for sites that have already upgraded
to 2.15-rc0. This is likely okay since:
* the mute functionality didn't exist in 2.14 and hence for sites
that upgraded from 2.14 there was nothing to migrate
* it's unlikely that production sites were upgraded to the first
release candidate of a new release
* the mute labels are no critical data and are quickly outdated by
uploading new patch sets
2. Add a new schema migration that does the correct thing:
- We normally can't add schema migrations in stable branches because
they would conflict with schema migrations in master. But in this
case we don't have any new schema migration in master yet, so we
could do this instead.
The replacement of Mute/Unmute with Mark Reviewed/Unreviewed was
implemented in several steps (first add support for Mark
Reviewed/Unreviewed, then removal of Mute/Unmute). For the unlikely case
that sites run a version were both Mute/Unmute and Mark
Reviewed/Unreviewed was possible the schema migration now also handles
the case where a patch set has the 'mute' label in addition to a
'reviewed' or 'unreviewed' label. In this case we trust the new labels
and the 'mute' label is just dropped.
Change-Id: I0941b5584ae6be3c1bbb3b72594cb34e67e8a48c
Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.