| commit | ecc6799fbfff2ff980d66b408e7957200d7854d1 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Fri Dec 16 10:10:16 2022 +0100 |
| committer | Ben Rohlfs <brohlfs@google.com> | Mon Jan 09 19:47:48 2023 +0100 |
| tree | 0be30c50a20ff60f624927975f41e7afc3bbe2ab | |
| parent | 4c4ae50349b467bc481c54d9fd2811303a28aa7e [diff] |
Merge view state of DIFF and EDIT into CHANGE The motivation is that we want to move more control from views into models. In particular we would like to the change model (and the change view model) to control the patch range (patchNum and basePatchNum). The DIFF/CHANGE/EDIT views already share a change model, but they still had their own view model each. We want to works towards a unified view of which patchset range is currently selected. A clearly visible sign of the current messy design is that router model still has the references to change number and patchset numbers. This change will enable us to move this information into change view model in a follow-up change. We are not super happy with how the view models deal with hierarchies. The `childView` property and lots of optional properties that only make sense for some child views do not seem to be the ultimate clean design to this problem. But we are consistent here with other views (see admin and repo views), and we believe that this is better handled in a larger, separate effort. Our change definitely makes this simpler to achieve. In a follow-up we consider to add a wrapper between app-element and change-/diff-/edit-view. That will allow us to remove the app-element dependency on change model. And we will have a clear element that can act as the change model provider. Release-Notes: skip Google-Bug-Id: b/247042673 Change-Id: Ibf04e462ee76d830dbab02003288f4d7e99ecd13
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.