| commit | eb5eb7527eab368d668ae5471c2da1d3e524af79 | [log] [tgz] |
|---|---|---|
| author | Luca Milanesio <luca.milanesio@gmail.com> | Sat Jan 30 00:48:05 2021 +0000 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Thu Feb 25 23:01:44 2021 +0000 |
| tree | 5c4f5fb026224b4da153022bf071f7527b2d781b | |
| parent | 1bdfec2d4942347c8cdf5215ca0a9c4b9ff72b42 [diff] |
Stop SPAMming Gerrit logs with 'Logging context is not empty' Gerrit v3.1 started SPAMming error_log with a continuous series of warnings that the LoggingContext was not empty at the start of the execution of LoggingContextAwareRunnable. The warning is misleading because it doesn't reflect the situation where the logging context is dirty but just tells that at the start of the execution there is already one of the following elements of the thread-local storage already allocated: - tags - forceLogging - performanceLogging - performanceLogRecords Of the four objects stored in the thread-local storage, the performanceLogRecords is created well before the start of the execution and therefore will always be not null when the Callable wrapper gets invoked. Remove the condition on the performanceLogRecords so that the warning will fire if there is a real context dirty detected, apart from the performanceLogRecords that will be always set to a non-null value. Bug: Issue 12443 Change-Id: I6cf7db36165f7653ddb178f0cabe61faa13696e2
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.