Google Git
Sign in
gerrit / gerrit / ea4de32cdb1e6f1fc03ed3a92a9f7edeff6e4614
commitea4de32cdb1e6f1fc03ed3a92a9f7edeff6e4614[log] [tgz]
authorDhruv Srivastava <dhruvsri@google.com>Wed Mar 23 22:34:42 2022 +0530
committerDhruv Srivastava <dhruvsri@google.com>Thu Mar 24 15:03:11 2022 +0530
tree8f8bd4159090884878e29a93dcc2e3d04f8f9e78
parent6f76e57e6b7f7d0071fbc6a2cd96aeb54a819ee1 [diff]
Simplify how blank cells in reply dialog are calculated

In the reply dialog we want to align the same vote value across
multiple labels.
In case some labels don't share the same range we add blank cells
as necessary to ensure the values of the votes are aligned across
labels.(https://imgur.com/a/fwIgJXL)

_computeColumns was a confusing function name, unclear from the name
exactly what it was doing and the LabelValuesMap can be removed hence
resolving the TODO(TS).

To calculate the cells we need to know the overall minimum and maximum
value to determine how many extra cells are needed.

Testing was done by making sure existing unit tests pass and verifying
layout looks correct on the change for which the screenshot is
attached.

Screenshot: https://imgur.com/a/fwIgJXL
Release-Notes: skip
Change-Id: If2d8155a235ecd32b4174730ec8fd1d858a9b25f
4 files changed
tree: 8f8bd4159090884878e29a93dcc2e3d04f8f9e78
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.