| commit | e467a77df287a9ec4c65ccb171bb02d872c3aeb1 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Sep 29 14:49:23 2022 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Sep 30 11:22:15 2022 +0200 |
| tree | 6e17ba1bb73710500a6090a1754ed5ac1739757a | |
| parent | 4a628ac463027d1d475b7395edac7edf24de7990 [diff] |
Revert: Do not check the account visibility of reviewers/CCs If a change is reverted, Gerrit automatically adds the change owner and the reviewers of the reverted change as reviewers on the revert change. CCs of the reverted change are automatically added as CCs on the revert change. So far revert failed if any of the accounts that are added as reviewers/CCs on the revert change are not visible to the caller. Failing in this case is unnecessary since the user doing the revert already knows about the existence of the reviewer/CC accounts (see below) and hence we can just skip the account visibility check for them during revert. Reverting a change is only possible if the calling user can see the change that is being reverted. If a user can see the change, they can also see the change owner and all its reviewers/CCs regardless of whether these accounts are visible. This means the user doing the revert knows that Gerrit accounts exists for all users the are either change owners, reviewer or CC on the reverted change. This means we can preserve them as reviewers/CCs on the reverted change, even if their accounts are not visible to the user doing the revert (as it doesn't expose the existence of accounts that the user didn't already know before). Signed-off-by: Edwin Kempin <ekempin@google.com> Release-Notes: skip Change-Id: I8264d96f7cb683c9becefd43d7cc84067d5f2409 Bug: Google b/249230938
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.