| commit | e787f97a7b8ecb41ea83600c481c81cfb119b74a | [log] [tgz] |
|---|---|---|
| author | Wyatt Allen <wyatta@google.com> | Fri Apr 27 15:14:45 2018 -0700 |
| committer | Paladox none <thomasmulhall410@yahoo.com> | Thu May 03 15:54:43 2018 +0000 |
| tree | d6dee55edf73507eaba3942482a4bd3dbc639c43 | |
| parent | bd48870511524105ed24b5958ff4274784721296 [diff] |
Clear suggestions on autocomplete input change The gr-autocomplete component re-evaluates suggestions on input changes via an observer. Since evaluating suggestions is typically asynchronous (and debounced) there is a window of time between the keystroke that triggers the re-evaluation and the time that the new suggestions populate the `_suggestions` array (potentially replacing any old suggestions). If a modestly fast typer has typed an input resulting in suggestions, but then, in quick succession, typed additional text (invalidating the suggestions and triggering a request for new ones) followed by a "commit" keystroke (such as [Enter] or [Tab]), then the autocomplete may incorrectly commit to one of the invalidated suggestions. Doing so would revert the input value to the text that triggered the old suggestion, effectively erasing the newly typed characters. With this change, the suggestion list is eagerly emptied whenever new input is typed. This ensures that the `_suggestions` array is empty during the window that new suggestions are inbound. Bug: Issue 8655 Change-Id: I85bb519985903af719ef287860c04cc97b6cbca8 (cherry picked from commit 8f3fa7532537eb994889b4147aa6b909b40d2c59)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.