commit e770374b7da6bb8c6aa829d005bba412c5312a9f
author Paladox none <thomasmulhall410@yahoo.com> Wed Jul 10 20:31:56 2019 +0000
committer Paladox none <thomasmulhall410@yahoo.com> Wed Jul 10 20:58:21 2019 +0000
tree 580c6d103fa7d85458912e7ef1cadbac4ea97fa3
parent af6074665ea318c5d2766051bda5e719324c9d43

gr-change-metadata: Add undefined checks

This is to support Polymer 2 in the embed test.

Bug: Issue 10930
Change-Id: Ib810e688506569db2d83f6d38c825b459de576be

polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.js

diff --git a/polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.js b/polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.js
index 51fa1b0..154fc36 100644
--- a/polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.js
+++ b/polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.js
@@ -222,12 +222,14 @@
     },
 
     _showAddTopic(changeRecord, settingTopic) {
-      const hasTopic = !!changeRecord && !!changeRecord.base.topic;
+      const hasTopic = !!changeRecord &&
+          !!changeRecord.base && !!changeRecord.base.topic;
       return !hasTopic && !settingTopic;
     },
 
     _showTopicChip(changeRecord, settingTopic) {
-      const hasTopic = !!changeRecord && !!changeRecord.base.topic;
+      const hasTopic = !!changeRecord &&
+          !!changeRecord.base && !!changeRecord.base.topic;
       return hasTopic && !settingTopic;
     },
 
@@ -406,7 +408,7 @@
      * @return {Object|null} either an accound or null.
      */
     _getNonOwnerRole(change, role) {
-      if (!change.current_revision ||
+      if (!change || !change.current_revision ||
           !change.revisions[change.current_revision]) {
         return null;
       }