e6d550e5593d0800c096b0d9da42272c66938eb3 - gerrit

commit	e6d550e5593d0800c096b0d9da42272c66938eb3	[log] [tgz]
author	David Ostrovsky <david@ostrovsky.org>	Wed Jul 09 23:55:11 2014 +0200
committer	David Pursehouse <david.pursehouse@sonymobile.com>	Thu Jul 10 15:24:24 2014 +0900
tree	c02c3dac6cb927ba712773ef1caa555f453675a1
parent	17aa3fe3eeb4a4811ec30976e575436f9b0ef2ae [diff]

Fix wrong Guice wiring

BanCommit and SuggestParentCandidates Guice beans were using assisted
inject pattern.  The factories were bound in request scope module even
though both beans have nothing to do with request scope.

Fix it by dropping unnecessary assisted inject bindings and move the
beans into singleton scope.

Change-Id: Ia792fb0db60e594456034c1517468a309393f5b5

gerrit-server/src/main/java/com/google/gerrit/server/config/GerritRequestModule.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/git/BanCommit.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/project/SuggestParentCandidates.java[diff]
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/BanCommitCommand.java[diff]
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProjectCommand.java[diff]

5 files changed