| commit | e631de23eae6270a6f0a21936f8d3312c1faea30 | [log] [tgz] |
|---|---|---|
| author | Gal Paikin <paiking@google.com> | Thu Oct 29 12:19:11 2020 +0100 |
| committer | Gal Paikin <paiking@google.com> | Wed Nov 04 12:11:22 2020 +0100 |
| tree | f00b2648a0822dd2ac616c7ec34ec6af382b31f8 | |
| parent | 0f65e01a3bba994287b1f771f084bdf51d6e1c8f [diff] |
Ensure users are active on the change when adding to attention set Until now, it was technically possible to add users to the attention set even if they had no interactions on the change. This is a minor bug since the frontend took care of this even if such a thing happened, and also it required users to manually do it using the REST API. This change ensures users can't be added to the attention set if they are not active (reviewer, cc, owner, uploader) on the change. On reply, we don't throw an error when trying to add an inactive user (but rather just ignore it in ChangeUpdate). The reason for this is the fact it's complicated to calculate the current reviewers since on reply we can also add new reviewers (which would require "resolving" all new reviewers unnecessarily, which is a latency concern, In ChangeUpdate it's done anyway so we can check it there). Tests that allowed adding to the attention set when the user was not active in the change had to be updated. Change-Id: Icd779ce3b4c766a1a941680cde5d2b87d055b553
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.