commit e5ee0d386536da0371f29ec27a78cd0753dc04d7
author Dave Borowitz <dborowitz@google.com> Mon Dec 12 12:58:32 2016 -0500
committer Dave Borowitz <dborowitz@google.com> Mon Dec 19 09:21:35 2016 -0500
tree 144d09df96be84904444d8b0f03fc43e79b1779f
parent 81f334a77fb83aaaca7ec5b41c65da4f397fa0cf

Support setting current patch set in NoteDb

Until now, NoteDb was not explicitly recording the current patch set,
and instead just assuming that the highest-numbered non-deleted patch
set was current. This is usually fine, but there is at least one
corner case where it's not.

Specifically, when pushing an old patch set of a change directly to a
branch:

 * The change moves to state MERGED.
 * The currentPatchSetId field gets set to the corresponding patch
   set ID of the merged commit, even if this is less than the maximum
   patch set in the database.

Teach NoteDb to handle this case with a footer "Current: true"
indicating the patch set mentioned in the "Patch-set" footer is the
current patch set. Creating a new patch set also implicitly sets it to
current, matching existing data.

Various parts of the code in ChangeRebuilderImpl and ChangeBundle were
assuming that any entities referring to patch sets greater than the
current patch set were ignorable. Remove this assumption, and ensure
we're handling these entities properly.

Add a test for the above case.

Change-Id: I099fd703458ffd63a31009ceaaa1c1d2c59d4669