| commit | e5b0919c9bb2b4e18861559f93f00d514d2d4af5 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Thu Apr 20 09:40:39 2023 +0200 |
| committer | paladox <thomasmulhall410@yahoo.com> | Thu Apr 27 17:39:32 2023 +0100 |
| tree | be5ae67ac72b09cb3749ff100599c496cd8d03b9 | |
| parent | 4ab354f1988bd36d8d6096c5658e3d499de85168 [diff] |
Fix comment context not showing up The `GrDiffGroup.startLine()` was throwing an exception for `skip` groups. So the comment context diff was sometimes not showing up. This was only an issue, if the number hidden lines before the comment was smaller than the context lines preference setting of the user. Otherwise a context control group would "hide" the skip group. This issue was only introduced by the new Lit diff builder. The legacy builder was not using the `startLine()` method. `skip` groups are not really rendered anyway. The `get...Pairs()` methods for such groups returns an empty array, so both the Legacy and the Lit diff renderer would not create any rows. But they do render a diff section of height 0. Release-Notes: skip Google-Bug-Id: b/278701532 Change-Id: I2ba38fe78621872ae73ddc3832b7df757d1fbe36
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.