| commit | e4ee65b6790a58aed570250e6800b9ed4b59df71 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Jun 05 09:44:13 2019 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Wed Jun 05 08:28:15 2019 +0000 |
| tree | 0473cdace47f3cfffece4e5a60be4be1801814d7 | |
| parent | cf5e35bd38ba3eb6c750578506abc7b7842543bf [diff] |
ReviewersUtil: Increase multiplier for candidate list to 3 Since the frontend reduced the number of suggested reviewers to 6 [1] we have users complaining about users being missing in the reviewer suggestion. This is because the account query to compute the reviewer candidates is limited to 2 x <limit-from-the-request>, which is 12 now. If there are more than 12 matches some accounts are dropped, which may contain the account that the user expects. In the case I debugged there were 15 candidates, out of which only 2 are suggested in the end. When the limit is set to 12, 1 of them got dropped. Increasing the multiplier for the candidate list to 3 shouldn't have bad impacts on the performance, basically 3 * 6 = 18 is still lower than the limit that we used before [1], 2 * 10 = 20, and that limit worked well. [1] https://gerrit-review.googlesource.com/c/gerrit/+/222655 Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ia3121d1708444b80a53a421f24f05a89c87ea80d (cherry picked from commit c528072d07a5293583cd19aed1ee23d743a93714)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.