commit | 885c2c30947c983b7c90e98766fa0893d03279bb | [log] [tgz] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Fri Mar 24 09:59:39 2017 -0700 |
committer | Dave Borowitz <dborowitz@google.com> | Fri Mar 24 17:53:27 2017 +0000 |
tree | e1b6492952bc98a59ed05da5253b71b1f97e0cd3 | |
parent | 604cdb290a831411c7b58cb2636bb30df4e7a84b [diff] |
ReceiveCommits: parseBody before getFooterLines The RevWalk in ReceiveCommits is used for walking commits in various places, some of which call parseBody on each commit and some that don't. The call to RevWalk#getFooterLines on line 1707 was clearly not preceded by a call to parseBody earlier in the same block; the fact that it managed to avoid throwing NPE most of the time is pure luck. We have a report of NPEs in the wild from this line. Make the obvious fix first, and if we end up having time we can go back and debug later how it happened. Change-Id: I5728bb6d46ae4c121c096379b07660f01f86d640
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.