Do not commit detailed account info in ChangeMessage
ChangeMessage is currently used to serve comments for some change
operations. Those comments are saved as commit message in NoteDb and as
part of ChangeNotesState proto in ChangeNotesCache and also indexed to
query by comments.
Instead of placing change message with account details to data storages,
put template messages and replaces them as needed.
In this change:
- 'message' field in ChangeMessage is persisted to data storages
(NoteDb, ChangeNotesCache, search index). It has a form of template, with
<GERRIT_ACCOUNT_ID> placeholder for the account details.
- 'accountsInMessage' are filled before the message is served to the
endpoints.
- ChangeAPI REST endpoints serves templates with 'accountsInMessage'
field.
- ChangeMessageAPI endpoints still serves replacements, with the plan
for future deprecation.
- Change messages in DeleteReviewer, DeleteVote and SetAssignee
operations are turned into templates.
- Frontend was already adjusted to replace templates with
user names in change https://gerrit-review.googlesource.com/c/gerrit/+/303801
Other operations can be fixed in the follow up change, with the
integration test to prevent regression.
Change-Id: I55e7185528bfc423aaef3d56c40c42c146580eaa
diff --git a/Documentation/rest-api-changes.txt b/Documentation/rest-api-changes.txt
index cf01be9..236a944 100644
--- a/Documentation/rest-api-changes.txt
+++ b/Documentation/rest-api-changes.txt
@@ -6682,7 +6682,12 @@
Set if the message was posted on behalf of another user.
|`date` ||
The link:rest-api.html#timestamp[timestamp] this message was posted.
-|`message` ||The text left by the user.
+|`message` ||
+The text left by the user or Gerrit system. Accounts are served as account IDs
+inlined in the text as `<GERRIT_ACCOUNT_18419>`.
+All accounts, used in message, can be found in `accountsInMessage`
+field.
+|`accountsInMessage` ||Accounts, used in `message`.
|`tag` |optional|
Value of the `tag` field from link:#review-input[ReviewInput] set
while posting the review. Votes/comments that contain `tag` with
