commit e2d06b05c181ce42fe2c5344807050528e0da5e3
author Edwin Kempin <ekempin@google.com> Wed Feb 17 18:34:17 2016 +0100
committer Edwin Kempin <ekempin@google.com> Thu Feb 18 08:32:00 2016 +0100
tree 48fd3683850cacaecd77f6cfd561719851ec9f3b
parent bf55fa403a4508b9c74a9c6d8dd72140868d7b0e

Remove unused ChangeUtil#updated method

Plugins that use this method must be adapted to use BatchUpdate for
updating changes, otherwise they can't work with notedb.

Change-Id: I5cdaa7fa532519d3650c2886a9ab5ae2b3d1a780
Signed-off-by: Edwin Kempin <ekempin@google.com>

Documentation/dev-plugins.txt

diff --git a/Documentation/dev-plugins.txt b/Documentation/dev-plugins.txt
index 13b6978..e61a725 100644
--- a/Documentation/dev-plugins.txt
+++ b/Documentation/dev-plugins.txt
@@ -1200,20 +1200,16 @@
   [...]
   // update change
   ReviewDb db = dbProvider.get();
-  db.changes().beginTransaction(change.getId());
-  try {
-    change = db.changes().atomicUpdate(
-      change.getId(),
-      new AtomicUpdate<Change>() {
-        @Override
-        public Change update(Change change) {
-          ChangeUtil.updated(change);
-          return change;
-        }
-      });
-    db.commit();
-  } finally {
-    db.rollback();
+  try (BatchUpdate bu = batchUpdateFactory.create(
+      db, project.getNameKey(), user, TimeUtil.nowTs())) {
+    bu.addOp(change.getId(), new BatchUpdate.Op() {
+      @Override
+      public boolean updateChange(BatchUpdate.ChangeContext ctx) {
+        ctx.saveChange();
+        return true;
+      }
+    });
+    bu.execute();
   }
   [...]
 }

gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
index bf93329..b694cd8 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
@@ -16,7 +16,6 @@
 
 import com.google.common.base.Function;
 import com.google.common.collect.Ordering;
-import com.google.gerrit.common.TimeUtil;
 import com.google.gerrit.reviewdb.client.Change;
 import com.google.gerrit.reviewdb.client.PatchSet;
 import com.google.gerrit.reviewdb.server.ReviewDb;
@@ -87,10 +86,6 @@
     }
   }
 
-  public static void updated(Change c) {
-    c.setLastUpdatedOn(TimeUtil.nowTs());
-  }
-
   public static PatchSet.Id nextPatchSetId(Map<String, Ref> allRefs,
       PatchSet.Id id) {
     PatchSet.Id next = nextPatchSetId(id);