commit | e294f7bccce1de488fb5cd8f73ee5ebd11c41da9 | [log] [tgz] |
---|---|---|
author | Luca Milanesio <luca.milanesio@gmail.com> | Sun Apr 28 12:30:39 2019 +0100 |
committer | David Pursehouse <dpursehouse@collab.net> | Mon Jun 10 13:57:12 2019 +0900 |
tree | e7998f9a6266b640ede8fe66b2d1222a694cbf02 | |
parent | 9bf22615762d60954f4446af6ce625a98895b5c5 [diff] |
Avoid evaluating submit rules twice for open changes When getting the submit record for a change, the allowClosed() option is irrelevant for extracting the submit record. The change details REST-API ask for the submit record with both strict and lenient modes, which are exactly the same mode for an open change, but trigger two evaluations of the submit rule. When using complex Prolog rules that extract a lot of information, the extra execution could add significant delay and put unnecessary pressure to the CPU. When using plugins for submit rules that do extensive processing of the commit tree, the double evaluation causes even more stress to the filesystem bacause of the double processing Git tree and BLOBs. Bug: Issue 10790 Change-Id: I2d77cf93b53720d6c92745a701358c2489e7a9e7
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.