commit e2488441927dde2820918d999bd7088a76fca7e6
author Shawn O. Pearce <sop@google.com> Thu May 27 15:58:36 2010 -0700
committer Shawn O. Pearce <sop@google.com> Thu May 27 15:58:36 2010 -0700
tree 2462ecb0965ef0b7e710c4b0d4cafe1962c71cbe
parent 702810d11e127012fead4617c792bac2e82be368

Make project metadata visible to anonymous users

Since we now permit showing the metadata about a project in a
non-editable format to non-owners of that project, lets finish
opening up the UI and permit anonymous users to also see the
metadata if they can see the project.

Change-Id: I7ed0620579f9778686242acdba28e225300bad00
Signed-off-by: Shawn O. Pearce <sop@google.com>

gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java

diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java
index 355ab4a..b5a986f 100644
--- a/gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java
+++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java
@@ -29,10 +29,8 @@
 
 @RpcImpl(version = Version.V2_0)
 public interface ProjectAdminService extends RemoteJsonService {
-  @SignInRequired
   void visibleProjects(AsyncCallback<List<Project>> callback);
 
-  @SignInRequired
   void projectDetail(Project.NameKey projectName,
       AsyncCallback<ProjectDetail> callback);
 
@@ -49,7 +47,6 @@
       String groupName, String refName, short min, short max,
       AsyncCallback<ProjectDetail> callback);
 
-  @SignInRequired
   void listBranches(Project.NameKey projectName,
       AsyncCallback<ListBranchesResult> callback);
 

gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAdminScreen.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAdminScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAdminScreen.java
index 1d310c3..6be8657 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAdminScreen.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectAdminScreen.java
@@ -17,7 +17,7 @@
 import com.google.gerrit.client.Dispatcher;
 import com.google.gerrit.client.Gerrit;
 import com.google.gerrit.client.rpc.ScreenLoadCallback;
-import com.google.gerrit.client.ui.AccountScreen;
+import com.google.gerrit.client.ui.Screen;
 import com.google.gerrit.common.data.ProjectDetail;
 import com.google.gerrit.reviewdb.Project;
 import com.google.gwt.event.logical.shared.SelectionEvent;
@@ -28,7 +28,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
-public class ProjectAdminScreen extends AccountScreen {
+public class ProjectAdminScreen extends Screen {
   static final String INFO_TAB = "info";
   static final String BRANCH_TAB = "branches";
   static final String ACCESS_TAB = "access";

gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
index 97f1224..642712a 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
@@ -17,9 +17,9 @@
 import com.google.gerrit.client.Dispatcher;
 import com.google.gerrit.client.Gerrit;
 import com.google.gerrit.client.rpc.ScreenLoadCallback;
-import com.google.gerrit.client.ui.AccountScreen;
 import com.google.gerrit.client.ui.Hyperlink;
 import com.google.gerrit.client.ui.NavigationTable;
+import com.google.gerrit.client.ui.Screen;
 import com.google.gerrit.client.ui.SmallHeading;
 import com.google.gerrit.common.PageLinks;
 import com.google.gerrit.reviewdb.Project;
@@ -33,7 +33,7 @@
 
 import java.util.List;
 
-public class ProjectListScreen extends AccountScreen {
+public class ProjectListScreen extends Screen {
   private ProjectTable projects;
 
   @Override

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/VisibleProjects.java

diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/VisibleProjects.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/VisibleProjects.java
index 9d778f1..2588350 100644
--- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/VisibleProjects.java
+++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/VisibleProjects.java
@@ -18,11 +18,12 @@
 import com.google.gerrit.httpd.rpc.Handler;
 import com.google.gerrit.reviewdb.Project;
 import com.google.gerrit.reviewdb.ReviewDb;
-import com.google.gerrit.server.IdentifiedUser;
+import com.google.gerrit.server.CurrentUser;
 import com.google.gerrit.server.project.NoSuchProjectException;
 import com.google.gerrit.server.project.ProjectControl;
 import com.google.gwtorm.client.OrmException;
 import com.google.inject.Inject;
+
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
@@ -34,12 +35,12 @@
   }
 
   private final ProjectControl.Factory projectControlFactory;
-  private final IdentifiedUser user;
+  private final CurrentUser user;
   private final ReviewDb db;
 
   @Inject
   VisibleProjects(final ProjectControl.Factory projectControlFactory,
-      final IdentifiedUser user, final ReviewDb db) {
+      final CurrentUser user, final ReviewDb db) {
     this.projectControlFactory = projectControlFactory;
     this.user = user;
     this.db = db;