| commit | c14d87b01f51ea659f0e9474815a7551859a0cf0 | [log] [tgz] |
|---|---|---|
| author | Jacek Centkowski <geminica.programs@gmail.com> | Thu Jul 13 06:21:16 2023 +0200 |
| committer | Jacek Centkowski <geminica.programs@gmail.com> | Tue Jul 18 08:10:59 2023 +0200 |
| tree | 6a715073e769e7f0e2edf4d07234a2cd1a25bc43 | |
| parent | 535fe0786e57acdf32bfa7860c5c8a86aec0617e [diff] |
Fix project name's based submetric names collision At present submetric name in CallbackMetricImpl1 is a subject of simple sanitization rule: `/` chars are replaced with `_`. This is ok for majority submetrics (e.g. those related to JVM) but not enough for the limited set based on the project name (e.g. 'jgit/block_cache/cache_used_per_repository'). Luckily project name is a subject of characters restriction, nevertheless it leads to incorrect behaviour e.g. both `repo_name` and `repo/name` end up to be santized to the same `repo_name`. Before [1] that resulted in metrics being no longer available whereas now it results in values being reported for wrong repository. In order to solve it introduce a dedicated Field builder that is meant to be used to extract value from project name (called Field.ofProjectName). It sanitizes (during format) the received value so that only names that match the `[a-zA-Z0-9_-]+([a-zA-Z0-9_-]+)*` are allowed (that is a requirement for submetric name). Not matching characters are replaced with `_[HEX CODE]_` (code is capitalized) string. Considering that: * `repo_name` matches the pattern and remains unchanged * `repo/name` is sanitized to `repo_0x2F_name` * `repo_0x2F_name` becomes `repo_0x_0x2F_name` and collistion is avoided. Note that only Gerrit's core metrics that are based on project name are affected. [1] https://gerrit-review.googlesource.com/c/gerrit/+/369415 Bug: Issue 40015585 Release-Notes: Breaking change: project based submetric name is sanitized with more rules than just changing `/` to `_` Change-Id: I8f72aa47cb60e9716fea9e9b9a1d047256fe697d
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.