| commit | e1b2ad34bc67481d3bd7f7c45e68626373b455f0 | [log] [tgz] |
|---|---|---|
| author | Stefan Beller <sbeller@google.com> | Tue Nov 29 14:54:13 2016 -0800 |
| committer | Stefan Beller <sbeller@google.com> | Wed Dec 07 10:04:31 2016 -0800 |
| tree | adf892dfc127d1644c49864e15dcdd9001b5bc44 | |
| parent | 27d3f29137dc1b6bd7f738493f4a39eef3c62e7c [diff] |
PreviewSubmit: fix generation of compressed tar entries For the PreviewSubmit call plain tar as well as zip works fine, but formats like tbz2, tgz and txz are broken. This bug comes from not knowing the size of the bundles before writing them, such that it was assumed to 0. Plain tar as well as zip worked just fine as the tools ignored the wrong size. Fix the bug by creating the bundle in memory and then correctly use JGits ArchiveCommand for different formats. To demonstrate the bug is fixed, add a test that just lists files in the return of a call of preview submit call with tgz format specificed. By this change a bundle cannot be streamed any more, but needs to be kept in memory. As bundles may become large, introduce a new config option to set an upper bound for a bundle that is build up in memory. A slightly unrelated change is the wrapping of the ArchiveOutputStream in a try-with-resource block as it implements AutoCloseable. (Before it was not closed explicitly but just finish()ed.) Change-Id: I587c0e81ed79be94d7abf2a19ad2086c005933d9 Signed-off-by: Stefan Beller <sbeller@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.