| commit | 16f49ddd490b65bf0aecfdc81bc9b667d2573257 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Fri Mar 31 09:56:06 2017 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Fri Apr 07 11:56:59 2017 -0400 |
| tree | ad62d41dcd7c9b10da6c4b8449e8405720e08b71 | |
| parent | 77b0bbf3dbf581039ef704a2c08e3690a2776246 [diff] |
RebaseChangeOp: Take resolved ObjectId in Factory We want to remove access to the raw Repository from RepoContext. RebaseChangeOp was calling Repository#resolve on the baseCommitish argument, which is hard to emulate in a restricted implementation. Fortunately, it turns out that the resolve functionality was never actually used, except to look up an exact SHA-1 or ref name. Specifically, RebaseChangeOp.Factory#create was only called from 2 places: * In RebaseSubmitStrategy, it always passed a SHA-1. * In Rebase, it passed the result of findBaseRev, which was always either null, the dest branch name, or a SHA-1 (via RebaseUtil#parseBase). We can simplify things while keeping the same behavior by just moving the ref lookup logic into findBaseRev, so that method never returns null, and always returns an ObjectId. Then we can use a strong ObjectId type as an argument to RebaseChangeOp.Factory, such that RebaseChangeOp#updateRepo doesn't need to do anything special that requires a Repository. Change-Id: I578e578bf5f2e6431b074e6f6c183d3c96ef93ca
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.