Fix improper event reference for Safari The keyboard shortcut behavior's shouldSuppressKeyboardShortcut method mistakenly referred to the source event via `window.event`, but still worked in browsers that provide `window.event` for legacy reasons. Bug: Issue 6759 Change-Id: Iba97ffb3f9a073439af03e74466756138dcadeb2
diff --git a/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.html b/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.html index ca94495..8ce43b3 100644 --- a/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.html +++ b/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.html
@@ -42,7 +42,7 @@ shouldSuppressKeyboardShortcut(e) { e = getKeyboardEvent(e); - const tagName = Polymer.dom(event).rootTarget.tagName; + const tagName = Polymer.dom(e).rootTarget.tagName; if (tagName === 'INPUT' || tagName === 'TEXTAREA') { return true; }
diff --git a/polygerrit-ui/app/elements/admin/gr-project-detail-list/gr-project-detail-list.js b/polygerrit-ui/app/elements/admin/gr-project-detail-list/gr-project-detail-list.js index 859044f..edaf49a 100644 --- a/polygerrit-ui/app/elements/admin/gr-project-detail-list/gr-project-detail-list.js +++ b/polygerrit-ui/app/elements/admin/gr-project-detail-list/gr-project-detail-list.js
@@ -166,8 +166,8 @@ this._isEditing = false; }, - _handleSaveRevision() { - this._setProjectHead(this._project, this._revisedRef, event); + _handleSaveRevision(e) { + this._setProjectHead(this._project, this._revisedRef, e); }, _setProjectHead(project, ref, event) {