| commit | e0d99b50520cbd96d6b4ff9ba164abe5fbb9c64e | [log] [tgz] |
|---|---|---|
| author | David Pursehouse <dpursehouse@collab.net> | Sun Jun 02 22:25:04 2019 +0200 |
| committer | David Ostrovsky <david@ostrovsky.org> | Thu Oct 10 03:55:45 2019 +0200 |
| tree | 58b1c34327d60ffc8888f7ded6ec7dfe86b88e6b | |
| parent | 13087ddb1cdf15762810eed4b2e14b3ca275f02f [diff] |
Allow to enable git protocol version 2 for upload pack
When receive.enableProtocolV2 is set to true, set the necessary extra
parameters on the UploadPack to tell JGit to handle the request with
protocol v2.
Note that according to JGit's implementation, the git config on the
repository on the server must also be configured to use protocol v2.
This can be achieved either by setting it globally in the gerrit
user's ~/.gitconfig or per repository in the repository's .git/config:
[protocol]
version = 2
Test plan:
- Set protocol.version to 2 in the project's server-side config (or
in the gerrit user's ~/.gitconfig)
- Clone the project over SSH or HTTP
- From the client, run:
GIT_TRACE_PACKET=1 git -c protocol.version=2 ls-remote
(one can also configure this permanently on the local project by
running `git config protocol.version 2`)
- Observe the packet output including:
git< version 2
Reason for revert: The original revert was done because of security
vulnerability. Ref advertise filter was not called by Git v2 protocol
JGit layer. Gerrit does not rely any more on ref filter being called
by JGit. Gerrit provides a custom repository to JGit. The repository
provides a RefDatabase that is permission-aware and will only ever
return refs that the user has access to.
This reverts commit f51a97d523fd3022c1c8892c2481047c65cdc160.
Feature: Issue 9046
Helped-by: David Ostrovsky <david@ostrovsky.org>
Helped-by: Jonathan Nieder <jrn@google.com>
Change-Id: I0afdad7a9c2c946c6a2d9761837e8ece47517f49
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.