| commit | dfe9cbd80aff0091f0659ddb0d6064c113498ed8 | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Mon Dec 20 15:38:03 2021 +0100 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Tue Dec 28 10:52:23 2021 +0100 |
| tree | f216ba6a1c606d16f2d9c6a80de19263ca594e89 | |
| parent | fd092aae6e572fee23c828c3d32bc75b64487458 [diff] |
Read SRs from the revision note of the last PS that has stored SRs For closed changes, the current implementation loads submit requirements from the revision notes of all revisions. This was based on the assumption that SRs will be stored with the latest revision at the time of abandon. This assumption is problematic for changes that contain SR results in different revision notes. One scenario for this is when a change is abandoned, restored, updated (by uploading new patchsets) and then abandoned again. With each abandon we store SR results in the revision note of the latest patchset. This leads to duplicate SRs when we read them back from NoteDb. We also updated the computation of storing/parsing persisted SR results from NoteDb: We store a SR section in the revision notes upon merge/abandon even if SRs are empty (i.e. project did not configure any SRs). While parsing SRs from NoteDb, we account for this case by setting SRs = null if there is a corresponding SR section in the revision note, or an empty list if there is a SR section in NoteDb but is empty. Google-Bug-Id: b/211412218 Change-Id: Ia2fc726799ab338be40b7096444336e89bf05538
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.