| commit | ddf6fe57d19e821576da501aac94003b6cde353f | [log] [tgz] |
|---|---|---|
| author | Alice Kober-Sotzek <aliceks@google.com> | Wed Sep 09 15:06:23 2020 +0200 |
| committer | Alice Kober-Sotzek <aliceks@google.com> | Wed Sep 09 15:16:24 2020 +0200 |
| tree | ec023047c773be3bbb814f5857608fadaf480bbb | |
| parent | 9c38d22cc23836605a8ffb1d3abc34b9e2d9fe57 [diff] |
Make porting comments resilient to diff failures The diff computation can run into various errors, ranging from a diff temporarily not being available due to replication lag in a multi-master setup to the diff not existing as the auto-merge commit creation failed. As comments are ported from various patchsets and sources (e.g. patchset commits vs. parent commits vs. auto-merge commit), a single failure would have meant that no ported comments were available with the previous code even though some of them could have been successfully ported. This change increases the resilience of the ported comments endpoint by catching individual diff errors and mapping only the affected comments to a fallback position instead. At the moment, the fallback is the patchset-level. If the diff errors don't occur on a later request anymore, the corresponding comments will be ported as usual. To test this error situation, we add unit tests. Unfortunately, ChangeNotes is a very rich class referring to many other non-value classes. Hence, we mock it. To simplify unit testing, we might consider to refactor CommentPorter in the future to not use ChangeNotes as method parameter. Instead, we could introduce a new value class which provides the small amount of value classes (Change, Patchset instances, Project.NameKey) CommentPorter needs. Change-Id: I307c9b3a2d93668097b84d5f83345f8c9f49a1d4
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.