MergeOp: Retry after computing ChangeSet The problem with retrying the entire Submit operation when submitting a topic is that submit may have succeeded for the first project attempted, so the second attempt might fail unhelpfully with "Change N is merged". Somewhat fortunately, there was a bug in the retry logic that was preventing retrying from ever kicking in, because the UpdateException was wrapped in an IntegrationException before escaping from MergeOp. Fix this so that we can actually observe retry behavior in tests. Improve the situation by using a subtler approach of retrying submission of the entire ChangeSet, but using the same ChangeSet that was computed on the original attempt. This means that for some projects, the ChangeSet may, on retries, contain only merged changes. This requires minor tweaks to MergeOp and deeper in SubmitStrategyOp to correctly do nothing in that case. Behavior is still somewhat suboptimal because postUpdate steps are not run for the projects that succeeded on the first attempt, but this is not a regression. Additionally, there was already a race when multiple submissions were running at once, since MergeOp only checked the change state outside of the BatchUpdate, not within SubmitStrategyOp. For this reason, silently succeeding on already-merged changes is acceptable behavior. Generating a lock failure during tests is somewhat messy, because due to the implementation of FusedNoteDbBatchUpdate we need to actually insert a failing command into the BatchRefUpdate. Change-Id: Iae36e40369c40a125f6127125dc21e609c2b9b8d
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.