| commit | dd837aeea607f547ef6a41085f6f05fa59a8b2cb | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Tue Jun 18 11:42:14 2019 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Jul 18 16:00:27 2019 +0200 |
| tree | f6698430ad9b67f1219f3dcbd5e95b2e6a188fc0 | |
| parent | a4a8e5591816c5399cd1b6b4aa3b8ff86572dea7 [diff] |
Automatically retry REST operations on failure with tracing enabled On REST endpoint level we already retry the REST operation if there was a potentially temporary failure such as a LockFailure. Extend this to also retry once on non-recoverable failures, but with request tracing switched on. This is the same as if the user would retry the REST call with request tracing after it has failed. Capturing traces for failures automatically can help with debugging issues and safe roundtrips between user and supporting engineer. This only works for REST endpoints which support retrying (REST endpoints that extend RetryingRestModifyView or RetryingRestCollectionModifyView). Enabling more REST endpoints to retry is outside the scope of this change, but surely feasible. Submit has custom retry login in MergeOp. Adapt the retry in there too. Whether retry on failure should be done can be configured by setting retry.retryWithTraceOnFailure in gerrit.config (default = false). Since not all REST endpoints are atomic it can happen that a REST endpoint did some partial updates before it failed. If the operation is retried, in this case it can happen that this partial update is done again or that the failure is different now. This is OK since the chances for this are low and the same would happen if the user retries the operation. Change-Id: I2b78cbef50e5c3ce4fafce0d7cdcb3b1835abc86 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.