| commit | dc86ab526e6c58a94cad8c8c33effb16f8b5bfd9 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Tue Mar 15 13:13:57 2016 +0100 |
| committer | Dave Borowitz <dborowitz@google.com> | Tue Mar 29 12:56:20 2016 -0400 |
| tree | 2f651b13073989efa69083bf5375f0471e47766d | |
| parent | 273ca99db008875a86af91e7064bce476e5ab4c0 [diff] |
Fix PUBLISH_ALL_REVISIONS in NoteDb There was a bug in the PUBLISH_ALL_REVISIONS case where we passed the wrong PatchSet to PatchLineCommentsUtil.setCommentRevId, resulting in saving comments on the wrong side. Add a checkArgument to setCommentRevId that exposes this error, and fix it by passing the right PatchSet object. This means we may have to look up additional PatchSets for the change when writing to NoteDb. There is no way around this: if we publish a comment for PS1 when posting a review for PS2, we have not previously loaded PS1 to get the RevId, so we need to do that now. Test in CommentsIT for publishing comments on both sides simultaneously. Change-Id: Idbbc8d905a9e37ca6be9d45f8bddd0ca1fe0b248
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.